Open
Conversation
|
It's a little surprising you hit an issue here, the Sandstorm version already works correctly in this regard (EtherCalc is run in an iframe in Sandstorm), unless there's already some sort of fix on the Sandstorm branch specifically. |
Author
|
Of course, if it's a problem from your browser, it is probably a problem for many other users too, and so a fix will be important... I was just surprised you hit an issue here. :) |
Author
i'm using latest google chrome, so i think it's a big problem for much users |
Collaborator
|
works fine on Chrome for me. The /appeditor options used iframes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Hey everyone,
i'm using ethercalc in iframe (this is the only solution for my project), and i can't do export table, because JavaScript can't get window.parent.location.pathname from iframe.
I created a solutions, that check if this window is iframe, and if yes we can open file without window.parent.location.pathname.
Also remove unused spaces (my linter :))