Open
Conversation
Streamline is not installed by `npm i`, this results in executing the rule on each make invocation.
The first command of the rule of ethercalc.js is to echo in the target file, updating it's timestamp, so even if the second command fails, the rule won't be executed on next make invocation.
Uglify-js 2.14.5 uses deprecated functions that are no longer supported by latest node. npm (8.5.0) installs uglify-js 3.15.3 that uses modified command line options. With same source files, the newer uglify computes differents outputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8380bd3
From a master clone, after
npm ilaunchingmakerunnpm i --devthennode app.js --corslaunching the server.Everything is correct except that each time I run
makeagain, it always runsnpm i --dev.b94d176
Once the file static/ethercalc.js removed, while using node 12 or newer, make try to uglify and fails. But if I launch more times
make, instead of re-trying to uglify, it never does and launch the server. Connecting to it succeed but creating new page or open existing one result in a "TypeError: SocialCalc.Sheet is undefined" JavaScript exception in the browser like #729. And ethercalc.js contains only one comment.5b30fb5
Newer npm store more metadata.
82ce485
Like earlier, once the file static/ethercalc.js removed, while using node 12 or newer, make try to uglify and fails with the same error as #777. But running the same command with node v10 success and warn about deprecated function util.error. So this last commit update uglify-js, adapt option in Makefile and embed ethercalc.js and .map as the newer uglify uglifies differently the same source files.