AGroupBox.cpp: Enforce title to trigger over TextOverflow and block content text merge together with title text#571
AGroupBox.cpp: Enforce title to trigger over TextOverflow and block content text merge together with title text#571luadebug wants to merge 7 commits intoaui-framework:developfrom
Conversation
…ontent text merge together with title text
luadebug
changed the title
aui.views/src/AUI/View/AGroupBox.cpp
Outdated
| label->setTextOverflow(ATextOverflow::ELLIPSIS); | ||
| } | ||
| } | ||
| } << ".agroupbox-title", |
There was a problem hiding this comment.
Have you tried to put both AOverflow::HIDDEN and ATextOverflow::ELLIPSIS to .agroupbox-title?
There was a problem hiding this comment.
I think should do a trick
|
Does it really resolve #542 ? |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a rendering issue with AGroupBox by adjusting its stylesheet rules to fix how the title and frame interact, especially in overflow scenarios. The changes correctly enforce text clipping on the title and modify overflow properties for better visual consistency. The switch to a descendant selector (>>) for styling views within the title is a good, robust change. My only suggestion is to clean up a commented-out line that seems to be a leftover from debugging.
2 participants
Resolves #542
Frame and it's border once collision appear next to ALabel scrolled down, Frame's border should taint ALabel.