Conversation
|
Ignore the broken pipeline on windows. This PR is sufficient for start testing the rename proposal of @luadebug @AliaskaRuS what do you guys think about renaming
Arc is extremely comfortable to folks familiar with rust. In C++ world, the same concept is called |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the custom shared pointer implementation by renaming _ to AArc and _weak to AWeakArc. This is a great improvement for code readability and maintainability. The changes are mostly consistent, but I found one minor inconsistency that I've commented on. A more significant issue is that the test files using the old API (e.g., aui.core/tests/SharedPtrsTest.cpp) were not updated as part of this pull request. Please update the tests to use the new AArc and AWeakArc types to ensure the refactoring is complete and correct.
| */ | ||
| template <typename T> | ||
| static _weak<T> weak_from_this(T* raw) { | ||
| static AWeakArc<T> weak_from_this(T* raw) { |
No description provided.