Feat/co await improvements

[Alex2772]

I have made some adjustments for AUI's co_await support.

Generally my experience was good enough to switch from callback-based async handling to co_awaits.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the co_await support within the AUI framework, making asynchronous operations more robust and easier to integrate, particularly for void return types and thread management. It also expands image handling capabilities by adding JPEG saving functionality and enhances JSON serialization by supporting AMap types. These changes collectively aim to streamline development with AUI's asynchronous features and data handling.

Highlights

• C++20 Coroutines: Enabled C++20 coroutines by default in the build configuration.
• AFuture co_await Support: Enhanced AFuture to properly support co_await for void return types and ensured coroutine resumption occurs on the original caller thread.
• JPEG Image Saving: Added new functionality to save JPEG images to an output stream.
• JSON Conversion for AMap: Introduced JSON serialization and deserialization support for AMap<AString, T> types.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• aui.core/CMakeLists.txt
  • Enabled C++20 coroutines by default.
• aui.core/src/AUI/Thread/AFuture.h
  • Added CoPromiseType specialization for AFuture<void>.
  • Updated await_resume to correctly handle void futures.
  • Modified await_suspend to resume coroutines on the caller thread.
• aui.image/src/AUI/Image/jpg/JpgImageLoader.cpp
  • Implemented save method for writing JPEG images.
• aui.image/src/AUI/Image/jpg/JpgImageLoader.h
  • Declared save method for JpgImageLoader.
• aui.json/src/AUI/Json/Conversion.h
  • Added AJsonConv specialization for AMap<AString, T>.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces several improvements for co_await support in AUI, including enabling coroutines by default and enhancing AFuture to better handle void types and ensure thread consistency during coroutine resumption. However, a critical vulnerability was identified in the AFuture coroutine implementation: forcing resumption on the caller thread can lead to deadlocks and potential crashes on non-AUI managed threads. Additionally, there's a potential issue in the await_suspend implementation regarding mutable lambdas and a bug in JpgImageLoader::save where an incorrect parameter is passed to stbi_write_jpg_to_func (passing stride instead of a quality value). A minor performance improvement opportunity also exists in the AJsonConv specialization for AMap.