UPSTREAM PR #18526: model: fix SWA per-layer freq_base#776
Open
loci-dev wants to merge 1 commit into
Open
Conversation
|
Explore the complete analysis inside the Version Insights Perfect! I've retrieved the summary report for your project. Here are the key findings: Summary Report for llama.cpp PR #776Project Information:
Key Results: The analysis compared the base version against the target version and found:
Conclusion: |
118039a to
cd122e2
Compare
953f210 to
8b542ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#18526
I think the
if constexpr (iswa)can be wrong here, so pushing this PR for discussion.At least for gemma3, SWA layers are expected to use different freq_base than full attention layer. Using
if constexpr (iswa)will make it a fixed value cross all layers.Here is the original code of gemma3 (PR ggml-org/llama.cpp#12343) for reference: