Skip to content

Read Bower paths from nearest .bowerrc#80

Open
nguyenjustin214-lab wants to merge 1 commit into
austinpray:masterfrom
nguyenjustin214-lab:codex/bowerrc-discovery
Open

Read Bower paths from nearest .bowerrc#80
nguyenjustin214-lab wants to merge 1 commit into
austinpray:masterfrom
nguyenjustin214-lab:codex/bowerrc-discovery

Conversation

@nguyenjustin214-lab

Copy link
Copy Markdown

Fixes #22.

This updates Bower file discovery so callers do not have to pass paths.bowerDirectory/paths.bowerJson manually when those values can be discovered from the manifest path. If explicit options.paths are provided, those still take precedence.

Changes:

  • Walk upward from the manifest file to find the nearest .bowerrc or bower.json, then pass that directory to main-bower-files.
  • Stop assuming the component directory is literally named bower_components when matching package names, so custom .bowerrc directories work.
  • Keep Bower package exclusions as flat package names and add an integration regression for .bowerrc discovery.

Verification:

  • npm test
  • npm run jshint
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get bower paths from .bowerrc [$15]

1 participant