Recommended changes to get the CircleCI server to allow the tests for the React SPA web sample to succeed.#31
Open
djbauch wants to merge 17 commits into
Open
Recommended changes to get the CircleCI server to allow the tests for the React SPA web sample to succeed.#31djbauch wants to merge 17 commits into
djbauch wants to merge 17 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the test configuration and test scripts to enhance compatibility and improve the login test scenarios. The most important changes include switching from Puppeteer to Playwright, updating the login test scenarios, and modifying variable declarations.
Updates to test configuration:
codecept.conf.js: Changed the browser automation framework from Puppeteer to Playwright and updated the browser list to includechromiuminstead ofchrome. Also, updated the variable declaration fromvartoletfor theurlvariable. [1] [2]Enhancements to login test scenarios:
cant_login_spa_test.js: Added a new feature for SPA login with a responsive design and included a scenario for logging in using Lock.lock_login_spa_test.js: Updated the selector for the submit button in the login scenario to usebutton[type='submit']for consistency.