-
Notifications
You must be signed in to change notification settings - Fork 174
feat: add support for passwordless authentication methods on database connections EA #1282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kushalshit27
wants to merge
7
commits into
master
Choose a base branch
from
DXCDT-1366-sms-email-otp-passwordless-db-connections-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add support for passwordless authentication methods on database connections EA #1282
kushalshit27
wants to merge
7
commits into
master
from
DXCDT-1366-sms-email-otp-passwordless-db-connections-support
+15,584
−7,690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- src/tools/auth0/handlers/databases.ts: define authentication_methods schema with passkey, password, email_otp, and phone_otp - src/tools/auth0/handlers/databases.ts: add default_method property for authentication methods - src/tools/auth0/handlers/databases.ts: implement validatePasswordlessSettings method for validation logic
…dler - test/tools/auth0/handlers/databases.tests.js: implement tests for passwordless authentication methods - test/tools/auth0/handlers/databases.tests.js: ensure error is thrown for invalid password authentication settings - src/tools/auth0/handlers/prompts.ts: update ScreenRenderer type to use GetAculResponseContent
…onnections-support
…_password - src/tools/auth0/handlers/databases.ts: add default: false to disable_self_service_change_password property
…nge options - src/tools/auth0/handlers/databases.ts: modify error handling for password options - test/context/yaml/databases.test.js: add disable_self_service_change_password option in test cases
b63bb9f to
b50b692
Compare
428d42c to
e9b0f0f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1282 +/- ##
==========================================
- Coverage 80.28% 80.28% -0.01%
==========================================
Files 146 146
Lines 5823 5833 +10
Branches 1193 1197 +4
==========================================
+ Hits 4675 4683 +8
- Misses 655 656 +1
- Partials 493 494 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
email_otpandphone_otp) alongside existing password and passkey optionsauthentication_methodsconfiguration object with support for:email_otp.enabled- Enable email-based one-time password authenticationphone_otp.enabled- Enable phone-based one-time password authenticationpassword.enabled- Control whether password authentication is enabledpassword.api_behavior- Configure password behavior for API interactionsdefault_methodfield to identifier attributes (email,phone_number,username) to specify the default authentication method for each identifier typeExamples
YAML format
JSON format
{ "name": "Username-Password-Authentication", "options": { "authentication_methods": { "password": { "enabled": false }, "email_otp": { "enabled": true }, "phone_otp": { "enabled": true } }, "disable_self_service_change_password": true, "attributes": { "email": { "identifier": { "default_method": "email_otp" } }, "phone_number": { "identifier": { "default_method": "phone_otp" } } } } }📌 Note:
authentication_methods.password.enabledtofalse, you must also setdisable_self_service_change_passwordtotruepassword.enabledanddisable_self_service_change_passwordmust be set together; the validation will fail if only one is provided📚 References
🔬 Testing
password.enabledanddisable_self_service_change_passwordsettings📝 Checklist