fix: add fallback if userInfo.sub is not available#151
Open
remoblaser wants to merge 1 commit intoauthsmith:mainfrom
Open
fix: add fallback if userInfo.sub is not available#151remoblaser wants to merge 1 commit intoauthsmith:mainfrom
remoblaser wants to merge 1 commit intoauthsmith:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When trying to authenticate using a provider not returning a
subfield during the userInfo request, the plugin fails with a message:The following field is invalid: Sub. This is especially the case with Github and Discord.Solution
Use the
idfield returned during the userInfo request as a fallback. If that's not available, the whole thing will continue to fail.See also
Fixes #133