chore: better tracing (generator.GenerateSchema, WriteSchema)#2981
Open
miparnisari wants to merge 1 commit intomainfrom
Open
chore: better tracing (generator.GenerateSchema, WriteSchema)#2981miparnisari wants to merge 1 commit intomainfrom
miparnisari wants to merge 1 commit intomainfrom
Conversation
github-actions
bot
added
area/schema
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (74.80%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2981 +/- ##
==========================================
- Coverage 74.85% 74.80% -0.05%
==========================================
Files 499 499
Lines 61063 61072 +9
==========================================
- Hits 45703 45677 -26
- Misses 12174 12197 +23
- Partials 3186 3198 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miparnisari
force-pushed
the
add-ctx-to-GenerateSchema
branch
from
ececa4a to
99ffc8a
Compare
miparnisari
force-pushed
the
add-ctx-to-GenerateSchema
branch
from
99ffc8a to
dd4d1b6
Compare
miparnisari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to avoid having separate root traces for
generator.GenerateSchemaWithTypeSeton CheckPermission calls.Before:
After: