Skip to content

fix: tests#5

Open
zze0s wants to merge 17 commits into
masterfrom
fix/tests
Open

fix: tests#5
zze0s wants to merge 17 commits into
masterfrom
fix/tests

Conversation

@zze0s

@zze0s zze0s commented Mar 9, 2025

Copy link
Copy Markdown

Fix tests

@s0up4200

Copy link
Copy Markdown

I can't push to this one, but could it really be just this?

diff --git a/util_windows.go b/util_windows.go
index d0fc4fc..4a5b7cd 100644
--- a/util_windows.go
+++ b/util_windows.go
@@ -30,6 +30,5 @@ func shellRun(line, dir string) (string, error) {
 }
 
 func isEscapeRune(r rune) bool {
-	// TODO: Implement escaping (via `) on Windows
-	return false
+	return r == '\\'
 }

@zze0s

zze0s commented Apr 27, 2025

Copy link
Copy Markdown
Author

I can't push to this one, but could it really be just this?

diff --git a/util_windows.go b/util_windows.go
index d0fc4fc..4a5b7cd 100644
--- a/util_windows.go
+++ b/util_windows.go
@@ -30,6 +30,5 @@ func shellRun(line, dir string) (string, error) {
 }
 
 func isEscapeRune(r rune) bool {
-	// TODO: Implement escaping (via `) on Windows
-	return false
+	return r == '\\'
 }

Fixed your privs.

I'm pretty sure the code needs to be updated and fixed instead of changing the test case, but not 100% 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants