docs: troubleshooting cluster#16
Open
CliffordCheefoon wants to merge 3 commits intoautomotiveMastermind:clusterfrom
Open
docs: troubleshooting cluster#16CliffordCheefoon wants to merge 3 commits intoautomotiveMastermind:clusterfrom
CliffordCheefoon wants to merge 3 commits intoautomotiveMastermind:clusterfrom
Conversation
Contributor
|
LGTM!~ |
sjk07
approved these changes
Sep 7, 2021
Author
|
commit 5afbe46 validated for windows |
Contributor
|
@CliffordCheefoon Approved. just a few little things to tidy up =] |
sjk07
approved these changes
Jan 26, 2022
| if errRmGit != nil { | ||
| log.Fatalf("Error removing git folder at /tmp/"+folderName+". %s", errRmGit) | ||
| } | ||
| // commandRmGit := exec.Command("rm", "-rf", ".git") |
| secret, err := cmd.Output() | ||
| check(err) | ||
|
|
||
| os.MkdirAll(secretsDir, 0755) //if .secrets folder is missing, create |
Contributor
There was a problem hiding this comment.
keep comments above the code they relate to, not inline.
also since there is no if statement here. perhaps to show the true intention of the code its better to say ensure secrets folder is present. or something along those lines.
| // log.Fatalf("Error removing git folder at /tmp/"+folderName+". %s", errRmGit) | ||
| // } | ||
|
|
||
| removeGitError := os.RemoveAll(clusterRootPath + FPS + "tmp" + FPS + folderName + FPS + ".git") |
Contributor
There was a problem hiding this comment.
There is a native way in go to deal with os specific file path creation. filepath.Join()
I have refactored all of the FPS variable usage out of the code in a PR I wrote a while ago but wasn't merged yet. still a little WIP. #18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.