add readme and fix ambient light sensor only showing dimmed#2
Open
jayrox wants to merge 3 commits intoautonome:masterfrom
Open
add readme and fix ambient light sensor only showing dimmed#2jayrox wants to merge 3 commits intoautonome:masterfrom
jayrox wants to merge 3 commits intoautonome:masterfrom
Conversation
fixes the issue because the percent diff could be a negative value and -1000% isn't larger than the default 45 threshold. making the percent diff an absolute number means -1000% diff becomes 1000% diff and that is clearly larger than the 45 threshold.
Owner
|
Argh, how did I miss this! Sorry @jayrox :( Closing because the readme is out of date. I'll check if the ambient light change still applies. |
Author
|
It's ok @autonome. Have you made improvements? |
Owner
|
Yeah the README is much updated, so those changes aren't necessary now. The ambient light change makes me wonder if maybe the percentDifference function in /utils/shared.js maybe isn't right. Can you test and make the change there instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.