This repository was archived by the owner on Nov 25, 2025. It is now read-only.
Open
Conversation
ceyonur
approved these changes
Jun 5, 2025
alarso16
approved these changes
Jun 5, 2025
alarso16
reviewed
Jun 5, 2025
ceyonur
reviewed
Jun 6, 2025
|
|
||
| extData := customtypes.BlockExtData(ethBlock) | ||
| if !rules.IsApricotPhase1 { | ||
| if blockExtender.extDataHashes != nil { |
Collaborator
There was a problem hiding this comment.
i think removal of this what caused UTs to fail as we don't have extDataHashes for UTs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Personally, I find the current code hard to reason about.
How this works
extDataHashesrather than based on the claimedextData.extData.!rules.IsApricotPhase1cases into a single block.How this was tested
CI / visual inspection.
Need to be documented?
No.
Need to update RELEASES.md?
No