chore(customrawdb): delete customrawdb package and switch to avalanchego imports by powerslider · Pull Request #1319 · ava-labs/coreth

powerslider · 2025-10-03T12:56:12Z

Why this should be merged

Check ava-labs/avalanchego#4569

How this works

Delete plugin/evm/customrawdb.
Switch dependent code to using github.com/ava-labs/avalanchego/vms/evm/sync/customrawdb import instead.

How this was tested

successful build

Need to be documented?

no

Need to update RELEASES.md?

no

resolves ava-labs/avalanchego#4569

Signed-off-by: Tsvetan Dimitrov (tsvetan.dimitrov23@gmail.com)

…ego imports resolves #1302 Signed-off-by: Tsvetan Dimitrov (tsvetan.dimitrov23@gmail.com)

JonathanOppenheimer

Difference in this repository looks good - IMO, should not be merged until there's master commit that can be referenced.

plugin/evm/customtypes/hashing_test.go

powerslider · 2025-10-08T13:01:32Z

Added a DO NOT MERGE label until ava-labs/avalanchego#4387 is merged.

JonathanOppenheimer · 2025-10-08T15:06:34Z

I will review post AvalancheGo merger and when this PR is updated!

JonathanOppenheimer · 2025-10-24T19:42:58Z

@powerslider that PR is merged!

…cff8635e

Signed-off-by: Tsvetan Dimitrov <tsvetan.dimitrov23@gmail.com>

No longer approve in it's current state.

Handle database.ErrNotFound returned by ReadSyncRoot when there's no previous sync root. This is expected for fresh databases and should be treated as an empty hash (no previous sync) rather than an error.

Handle database.ErrNotFound from ReadAcceptorTip as expected case (empty hash) instead of error. This fixes VM initialization failures on fresh databases.

Update TestWipe to accept database.ErrNotFound as valid result after wipe, since ReadSnapshotBlockHash returns ErrNotFound when the marker doesn't exist.

- Move block number override fix before NewEVMBlockContext creation so GetHashFn can correctly resolve blockhash(n) when block number is overridden to n+1. This fixes TestTracingWithOverrides for Firewood scheme. - The bug was probably a pre-existing code issue where the header modification happened after creating the block context. Since GetHashFn creates a closure that captures the header reference, modifying the header afterward left the closure with stale values. This bug was exposed by the recent avalanchego update (3b08d6131a00bd55349321a58ae7e6cfcff8635e), which likely changed behavior that made the test fail specifically for Firewood scheme, while HashScheme continued to pass.

core/state/snapshot/journal.go

core/state/snapshot/wipe_test.go

scripts/build_test.sh

JonathanOppenheimer

See comments

- Extract sentinel errors in journal.go for better error checking and maintainability. - Refactor loadSnapshot to use switch statements for clearer control flow when validating snapshot block hash and root. - Improve TestWipe validation logic: - Use switch statements for consistent error handling patterns. - Add context to error messages ("before wipe" / "after wipe").

alarso16 · 2025-11-24T14:21:27Z

eth/tracers/api.go

 	h := block.Header()
+	// Apply block number override fix before creating block context so GetHashFn
+	// can correctly resolve blockhash(n) when block number is overridden to n+1.
+	if config != nil && config.BlockOverrides != nil && config.BlockOverrides.Number.ToInt().Uint64() == h.Number.Uint64()+1 {


Why is this change necessary? What does it do? I suspect you have may have found a solution to a persistent flake (see #1345)

Check the commit message here 755fda0

I'd defer this to @ARR4N as he put up the fix.

I cherry-picked these changes locally, and it didn't fix the flake.

I'd defer this to @ARR4N as he put up the fix.

This was a pseudo-cherry-pick (#1301) from an upstream security fix.

plugin/evm/vmtest/test_syncervm.go

alarso16 · 2025-11-24T14:22:43Z

core/state/snapshot/wipe_test.go

I defer to @ceyonur for this, but I think we should avoid making unnecessary changes in this package.

The changes were needed, because the test broke, but I also addressed some stylistic comments from @JonathanOppenheimer

Yeah minimal changes are ok, but I don't think you should make the stylistic changes he suggested

chore(customrawdb): delete customrawdb package and switch to avalanch…

79648df

…ego imports resolves #1302 Signed-off-by: Tsvetan Dimitrov (tsvetan.dimitrov23@gmail.com)

powerslider self-assigned this Oct 3, 2025

powerslider requested a review from a team as a code owner October 3, 2025 12:56

powerslider added 4 commits October 3, 2025 17:07

Merge branch 'master' into powerslider/1302-delete-customrawdb-package

2af6d7c

Merge branch 'master' into powerslider/1302-delete-customrawdb-package

a11cfcc

fix: rlpgen import issue and update to latest avalanchego version

dd36d2f

Merge branch 'master' into powerslider/1302-delete-customrawdb-package

faad5d5

powerslider force-pushed the powerslider/1302-delete-customrawdb-package branch from e96e06d to faad5d5 Compare October 6, 2025 11:01

ci: update ci.yml with the updated avalanchego version

375c1b0

powerslider requested a review from maru-ava as a code owner October 6, 2025 11:12

JonathanOppenheimer previously approved these changes Oct 6, 2025

View reviewed changes

plugin/evm/customtypes/hashing_test.go Outdated Show resolved Hide resolved

powerslider added 3 commits October 8, 2025 15:02

Merge branch 'master' into powerslider/1302-delete-customrawdb-package

4252f36

chore: update to latest avalanchego version

eb25364

fix: add input and output sorting for the comm command

b5c8955

powerslider added the Do not merge label Oct 8, 2025

powerslider added 5 commits November 5, 2025 13:36

Merge branch 'master' into powerslider/1302-delete-customrawdb-package

d1ba0fe

fix: change customrawdb calls in test_syncervm

950c6f0

Merge branch 'master' into powerslider/1302-delete-customrawdb-package

a757302

chore(go.mod) upgrade avalanchego to 3b08d6131a00bd55349321a58ae7e6cf…

7869716

…cff8635e

Merge branch 'master' into powerslider/1302-delete-customrawdb-package

56963ea

Signed-off-by: Tsvetan Dimitrov <tsvetan.dimitrov23@gmail.com>

powerslider removed the Do not merge label Nov 21, 2025

powerslider added 5 commits November 21, 2025 19:33

fix(statesync): handle ErrNotFound when reading sync root

214141d

Handle database.ErrNotFound returned by ReadSyncRoot when there's no previous sync root. This is expected for fresh databases and should be treated as an empty hash (no previous sync) rather than an error.

fix(vmtest): improve requireSyncPerformedHeight

327cee4

fix(statesync): handle ErrNotFound when reading sync root

44e841d

fix(core): handle ErrNotFound when reading acceptor tip

6ef6e9a

Handle database.ErrNotFound from ReadAcceptorTip as expected case (empty hash) instead of error. This fixes VM initialization failures on fresh databases.

fix(snapshot): handle ErrNotFound in wipe test

c0266f7

Update TestWipe to accept database.ErrNotFound as valid result after wipe, since ReadSnapshotBlockHash returns ErrNotFound when the marker doesn't exist.

powerslider added 2 commits November 21, 2025 20:19

ci: upgrade ci.yml avalanchego versions to correspond with go.mod change

fe604ac

JonathanOppenheimer reviewed Nov 21, 2025

View reviewed changes

core/state/snapshot/journal.go Outdated Show resolved Hide resolved

JonathanOppenheimer reviewed Nov 21, 2025

View reviewed changes

core/state/snapshot/wipe_test.go Show resolved Hide resolved

JonathanOppenheimer reviewed Nov 21, 2025

View reviewed changes

scripts/build_test.sh Outdated Show resolved Hide resolved

JonathanOppenheimer suggested changes Nov 21, 2025

View reviewed changes

powerslider added 2 commits November 24, 2025 11:42

Merge branch 'master' into powerslider/1302-delete-customrawdb-package

f75c4da

fix(scripts): remove unnecessary empty line

428048f

powerslider force-pushed the powerslider/1302-delete-customrawdb-package branch from e4b219d to 428048f Compare November 24, 2025 09:58

powerslider added 2 commits November 24, 2025 12:16

fix(customtypes): unalias math/rand package

5ee68ce

alarso16 reviewed Nov 24, 2025

View reviewed changes

powerslider added 2 commits November 24, 2025 16:32

Merge branch 'master' into powerslider/1302-delete-customrawdb-package

453a924

refactor(vmtest): simplify requireSyncPerformedHeight signature

5f0a462

JonathanOppenheimer approved these changes Nov 24, 2025

View reviewed changes

Merge branch 'master' into powerslider/1302-delete-customrawdb-package

861d8f1

Conversation

powerslider commented Oct 3, 2025

Why this should be merged

How this works

How this was tested

Need to be documented?

Need to update RELEASES.md?

Uh oh!

JonathanOppenheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

powerslider commented Oct 8, 2025

Uh oh!

JonathanOppenheimer commented Oct 8, 2025

Uh oh!

JonathanOppenheimer commented Oct 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JonathanOppenheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants