Skip to content

feat: pool nonce reliant RPCs#237

Merged
StephenButtolph merged 18 commits intomainfrom
JonathanOppenheimer/nonce-rpcs
Mar 20, 2026
Merged

feat: pool nonce reliant RPCs#237
StephenButtolph merged 18 commits intomainfrom
JonathanOppenheimer/nonce-rpcs

Conversation

@JonathanOppenheimer
Copy link
Copy Markdown
Contributor

@JonathanOppenheimer JonathanOppenheimer commented Feb 25, 2026

Closes #104.

Adds GetPoolNonce, which, on top of the gas RPCs, allows us to support 3 additional RPCs:

  • eth_getTransactionCount
  • eth_fillTransaction
  • eth_resend

I added a separate short unit test for each of these RPCs, as I couldn't find a neat way to fit them into any existing tests. Test EthGetters is not appropriate for eth_getTransactionCount IMO.

@JonathanOppenheimer JonathanOppenheimer self-assigned this Feb 25, 2026
@JonathanOppenheimer JonathanOppenheimer added the testing Related to testing efforts label Feb 25, 2026
@JonathanOppenheimer JonathanOppenheimer linked an issue Feb 25, 2026 that may be closed by this pull request
7 tasks
@JonathanOppenheimer JonathanOppenheimer force-pushed the JonathanOppenheimer/nonce-rpcs branch 3 times, most recently from a8a7b67 to eeb398e Compare March 4, 2026 22:25
@JonathanOppenheimer JonathanOppenheimer added the DO NOT MERGE This PR is not meant to be merged in its current state label Mar 4, 2026
@ceyonur ceyonur force-pushed the ceyonur/gasprice-api branch from 8cc0949 to 65abb83 Compare March 5, 2026 12:56
@JonathanOppenheimer JonathanOppenheimer force-pushed the JonathanOppenheimer/nonce-rpcs branch 2 times, most recently from daea4bb to 97f08b5 Compare March 5, 2026 17:23
Base automatically changed from ceyonur/gasprice-api to main March 10, 2026 12:24
@JonathanOppenheimer JonathanOppenheimer force-pushed the JonathanOppenheimer/nonce-rpcs branch from 97f08b5 to eac6cee Compare March 10, 2026 14:26
@JonathanOppenheimer JonathanOppenheimer removed the DO NOT MERGE This PR is not meant to be merged in its current state label Mar 10, 2026
@JonathanOppenheimer JonathanOppenheimer marked this pull request as ready for review March 10, 2026 14:27
@JonathanOppenheimer JonathanOppenheimer added the DO NOT MERGE This PR is not meant to be merged in its current state label Mar 10, 2026
@JonathanOppenheimer JonathanOppenheimer removed the DO NOT MERGE This PR is not meant to be merged in its current state label Mar 11, 2026
@JonathanOppenheimer JonathanOppenheimer force-pushed the JonathanOppenheimer/nonce-rpcs branch from 204b3cd to e8c58cf Compare March 13, 2026 15:11
JonathanOppenheimer and others added 4 commits March 17, 2026 11:18
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
JonathanOppenheimer and others added 4 commits March 17, 2026 13:04
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
JonathanOppenheimer and others added 3 commits March 19, 2026 11:35
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
@StephenButtolph StephenButtolph merged commit 17ce7b6 into main Mar 20, 2026
21 checks passed
@StephenButtolph StephenButtolph deleted the JonathanOppenheimer/nonce-rpcs branch March 20, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Related to testing efforts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API Support - Transaction pool methods

5 participants