This repository was archived by the owner on Dec 16, 2025. It is now read-only.
refactor: align accounts/abi/bind with coreth+upstream#1427
Merged
Conversation
added 2 commits
January 21, 2025 16:38
darioush
changed the title
ceyonur
previously approved these changes
Jan 22, 2025
qdm12
previously approved these changes
Jan 24, 2025
Contributor
qdm12
left a comment
qdm12
left a comment
There was a problem hiding this comment.
👍 Just a few minor comments
Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org>
Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org>
qdm12
approved these changes
Jan 27, 2025
ceyonur
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes changes to the
accounts/abi/bindpackage, focusing on renaming types and functions for consistency with upstream and coreth by moving some functionality to a new file.The most important changes include renaming
TmplContract,TmplMethod, andTmplStructtotmplContract,tmplMethod, andtmplStruct, respectively, and moving theBindHookfunction and related types to a new filebind_extra.go.This makes our modifications much clearer.
Some additional cosmetic changes are also reduced.