Bugfixes of TSX Instructions in features branch#36
Open
smetzlaff wants to merge 2 commits into
Open
Conversation
The explicit abort (XABORT) was not working properly. First, on issue the ReorderBufferEntry::issue() was continued after flushing the pipeline on XABORT, which caused erroneous behaviour. Second, in TsxCache::handle_upper_interconnect() the check_tsx_invalidated() function is called on XABORT, but it does not make sense, since it mixes the TsxStatus and TsxMESICacheLineState data types up.
The result of the XTEST instruction was wrong. According to the specification the ZF flag needs to be cleared, if the XTEST instruction is executed in a transaction. Otherwise the ZF flag is to be set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed two bugs regarding the Intel TSX specification: XABORT was not working. XTEST returned the wrong return code.