Fix dependency security alerts#124
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR addresses dependency security alerts by pinning
Confidence Score: 4/5The security patching and Next 15 migration are sound; the main rough edges are the eslint-config-next version mismatch and the .env.example losing COINGECKO_API_KEY, neither of which blocks a correct production build. The core work — dependency overrides, direct version pins, and the client-wrapper pattern — is correct and well-scoped. The eslint-config-next still at 14.0.1 while next is 15.5.18 means linting does not fully reflect the new framework version, and dropping COINGECKO_API_KEY from .env.example is a documentation gap that could silently affect developers setting up the project. package.json (eslint-config-next mismatch) and .env.example (missing COINGECKO_API_KEY, NODE_ENV=test) deserve a quick pass before merging. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["app/page.tsx\n(Server Component)"] -->|"imports"| B["BridgeSectionClient\n(bridge-section-client.tsx)\n'use client'"]
B -->|"next/dynamic ssr:false"| C["BridgeSection\n(bridgesection.tsx)\nbrowser-only widget"]
subgraph "Next 15 SSR Boundary"
A
end
subgraph "Client Boundary"
B
C
end
Reviews (1): Last reviewed commit: "Fix dependency security alerts" | Re-trigger Greptile |
| @@ -85,8 +85,76 @@ | |||
| "eslint": "^8.57.1", | |||
| "eslint-config-next": "14.0.1", | |||
There was a problem hiding this comment.
eslint-config-next is still pinned to 14.0.1 while next has been upgraded to 15.5.18. The eslint-config-next package ships Next.js-specific lint rules (App Router patterns, image optimisation, script loading, etc.) that are versioned alongside the framework. Running with a v14 config against a v15 app means any rules added or changed in Next 15 are silently absent, so the pnpm lint pass mentioned in verification may not be catching everything it should.
| "eslint-config-next": "14.0.1", | |
| "eslint-config-next": "15.5.18", |
| NEXT_PUBLIC_TRACK_USER_INTERACTIONS=true | ||
| NEXT_PUBLIC_TRACK_RESOURCES=true | ||
| NEXT_PUBLIC_TRACK_LONG_TASKS=true | ||
| NODE_ENV=test No newline at end of file |
There was a problem hiding this comment.
NODE_ENV in .env.example — Next.js actively overrides NODE_ENV at runtime (development for next dev, production for next build), so this value has no effect on the framework itself. However, other tools in the stack (Jest, testing libraries, some polyfill guards) do respect it unconditionally, so a developer who copies this file for local development and then runs non-Next scripts may get unexpected test-mode behaviour from those tools.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| NEXT_PUBLIC_ENVIRONMENT="test" | ||
| SEPOLIA_RPC_URL="https://sepolia.gateway.tenderly.co" | ||
| NEXT_PUBLIC_BRIDGE_API_URL="https://turing-bridge-api.fra.avail.so" | ||
| NEXT_PUBLIC_BRIDGE_INDEXER_URL="https://turing-bridge-indexer.fra.avail.so" | ||
| NEXT_PUBLIC_SUBSCAN_URL="https://avail-turing.subscan.io" | ||
| NEXT_PUBLIC_ETH_EXPLORER_URL="https://sepolia.etherscan.io" | ||
| NEXT_PUBLIC_COINGECKO_API_URL="https://api.coingecko.com/api/v3/simple/price" | ||
| NEXT_PUBLIC_BRIDGE_PROXY_CONTRACT="0x967F7DdC4ec508462231849AE81eeaa68Ad01389" | ||
| NEXT_PUBLIC_TOKEN_CONTRACT="0xb1c3cb9b5e598d4e95a85870e7812b99f350982d" | ||
| NEXT_PUBLIC_AVAIL_RPC="wss://turing-rpc.avail.so/ws" | ||
| NEXT_PUBLIC_ETHEREUM_NETWORK="sepolia" | ||
| NEXT_PUBLIC_SESSION_SAMPLE_RATE=100 | ||
| NEXT_PUBLIC_SESSION_REPLAY_SAMPLE_RATE=20 | ||
| NEXT_PUBLIC_TRACK_USER_INTERACTIONS=true | ||
| NEXT_PUBLIC_TRACK_RESOURCES=true | ||
| NEXT_PUBLIC_TRACK_LONG_TASKS=true | ||
| NODE_ENV=test No newline at end of file |
There was a problem hiding this comment.
The old
.env.example included COINGECKO_API_KEY and NEXT_PUBLIC_CMC_API_URL; both are absent from the new version. If any server-side API route or service still references COINGECKO_API_KEY, a developer bootstrapping from the updated example will deploy without that variable set and get silent failures or unexpected undefined values at runtime.
104d03a to
6f2f470
Compare
Summary
Verification
Notes