Avoid saving searches entirely; remove unneeded searches clean up job#6695
Open
Avoid saving searches entirely; remove unneeded searches clean up job#6695
Conversation
cjcolvar
force-pushed
the
no_saved_searches
branch
from
626c41b to
d31b508
Compare
cjcolvar
force-pushed
the
no_saved_searches
branch
from
d31b508 to
d7096b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #6654
This uses a Blacklight configuration to mark all searches as crawler agents and thus none should be saved.FIXME: Unit test is passing but I'm still seeing Search objects get persisted to the DB in local manual testing.2nd pass: override Blacklight method entirely because configuration was only applying to cases of non-logged in searches but we don't need searches saved for any requests.