Skip to content

Add Twitter code#59

Open
sukima wants to merge 1 commit intoavdi:masterfrom
sukima:feature/add-twitter-code
Open

Add Twitter code#59
sukima wants to merge 1 commit intoavdi:masterfrom
sukima:feature/add-twitter-code

Conversation

@sukima
Copy link

@sukima sukima commented Mar 24, 2016

Email isn't the only thing worth showing the code. With this you can create a DM twitter intent.

I tried to keep it simple by having a simple button group that toggles what will be produced when the submit button is pressed.

I was unable to test any of this due to lib v8 problems so here is the code and you can edit it as you wish.

Email isn't the only thing worth showing the code. With this you can
create a DM twitter intent.

I tried to keep it simple by having a simple button group that toggles
what will be produced when the submit button is pressed.

I was **unable** to test any of this due to
[lib v8](rubyjs/libv8#123) problems so here
is the code and you can edit it as you wish.
button#pick-twitter.button
| Twitter
.small-9.columns
input#badge-twitter.hide type="text" placeholder="@AwesomeCoder"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove @ during submit event or don't suggest to the user that they should provide one. Twitter does not allow the @ symbol as part of the DM message. For example the following is wrong:

DM @handle lorem ipsum

@bf4
Copy link
Collaborator

bf4 commented Mar 25, 2016

@sukima Thanks. Can you add a screenshot?

@sukima
Copy link
Author

sukima commented Mar 25, 2016

@bf4 I can not:

I was unable to test any of this due to lib v8 problems so here is the code and you can edit it as you wish.

bundle install will not finish and I can not run rails in this repo. So I do not know how to make a screen shot. I was hoping that you had some magical development environment were it runs so you could test it.

@hanneskaeufler
Copy link
Contributor

@sukima It's a stretch to thing you're still caring about this, I know :) But if you do, there is now instructions on how to use a docker container for spinning up a local dev version of the site. I might try your PR at some point to potentially include it, 4 years later 👍

@sukima
Copy link
Author

sukima commented Jan 23, 2020

Oh wow, hope it works. I honestly don't remember this. The sad truth is that dispute adding my PPWM links on all my social medias not a single person ever reached out to pair. Seems pairing is kinda dead, least under my little rock where I live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants