Performance Fix for Large Catalogs

[elevateweb]

Refer to this thread for the full issue. magento/magento2#278

We confirmed this issue Exists in Magento EE 1.13 Where for large catalogs we were experiencing out of memory issues due to this function _loadSkuSuperAttributeValues()

This patch will help those stores with large amounts of configurable products process large imports with hundreds of thousands of rows without hitting this issue as a bottleneck

[avstudnitz]

Thanks a lot.
Unfortunately, this breaks our unit tests:
Exception : Notice: Undefined variable: productIdArray in src/app/code/community/AvS/FastSimpleImport/Model/Import/Entity/Product/Type/Configurable.php on line 154
At least, the variable has to be initialized. More errors occur, I am not sure if they depend on this error.

[elevateweb]

I have initiated the variable and commited
Can you re-test and let me know if it fails on anything else for you

[nhp]

and the function definition yields strict errors (like when in dev mode)

[jzahedieh]

@nhp can you expand on what you mean, this fix seems good to me and it increases performance dramatically on a large catalog.

Do you mean the PHP docs?

 * @param array|null $bunch
 * @param array $newSku
 * @param array $oldSku

[nhp]

Sorry that it took me soo long.
The fix is a violation of the Liskov Principle because the function signature is not replaceable with each other.
I did a fix in here: nhp@fde43ef
Just forgot to do a PR

[avstudnitz]

Getting a PHP Fatal error: Call to undefined method AvS_FastSimpleImport_Model_Import_Entity_Product::_validate() on @nhp's version. Magento CE 1.7.

[ln8711]

@nhp The fix works for me with magento 1.9, thanks