Added fix for category positions#384
Open
barbazul wants to merge 2 commits intoavstudnitz:developfrom
Open
Conversation
|
I'm not working on Magento 1 anymore, but would be nice to get this solved/merged |
Collaborator
|
Thanks for your contribution. It is hard to understand though. Could you base your commit on the latest development branch and propose a new PR to the development branch, please? The pull request should only show your commits and no others. |
Contributor
Author
|
Is this better? |
Collaborator
|
This is much better, thanks! Once someone is able to work on the issues again, it should be possible to merge this after successful testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #281
This is not my solution, it's the solution provided by YouweGit@a458252 with some minor fixes (an array key) and an update to the Main integration test.
I also deprecated the existing logic for calculating position as it was incompatible with YouweGit fixes