Open
Conversation
Contributor
Author
|
@sprankhub can you check to see if this integrates what you did correctly please? |
Collaborator
|
Thanks @pixelhed! Most of the stuff looks good. Anyway, are you sure that this works correctly? I am missing the part, where I did not test though, I just did a code review. |
Contributor
Author
if you look here: you will see that it is set depending upon the type of link being imported. |
Collaborator
|
Okay awesome. As said, I could not test it, but you tested it, right? Did you also verify that imported downloadable files are structured in the way Magento does it usually (in subfolder à la /t/e/test.zip). If yes, I am happy to merge :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integrate refactoring done by @sprankhub in #393