fix: resolve false-positive configuration changes for Layers and Logg…#62
Open
jfeddern wants to merge 1 commit intoaws-actions:mainfrom
Open
fix: resolve false-positive configuration changes for Layers and Logg…#62jfeddern wants to merge 1 commit intoaws-actions:mainfrom
jfeddern wants to merge 1 commit intoaws-actions:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ingConfig
Issue #, if available:
#50
Description of changes:
Problem
The action incorrectly reported configuration changes when comparing Lambda function configurations, specifically for Layers and LoggingConfig.
This occurred because GetFunctionConfiguration returns different data structures than what UpdateFunctionConfiguration accepts:
This caused the deepEqual comparison to always fail, triggering unnecessary configuration updates and misleading users.
Solution
Added normalizeConfigValue() function to normalize configuration values before comparison:
Modified hasConfigurationChanged() to use normalization, ensuring accurate comparison between current AWS state and user-provided config.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.