feat: rm.IsSynced returns requeueError when false#597
feat: rm.IsSynced returns requeueError when false#597michaelhtm wants to merge 1 commit intoaws-controllers-k8s:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pkg/generate/code/synced.go
Outdated
| out += "\t\treturn false, nil\n" | ||
| out += fmt.Sprintf("\t\treturn false, %s\n", notSyncedErr) |
There was a problem hiding this comment.
Why do nil return trigger a 30 seconds requeue?
There was a problem hiding this comment.
not sure i understand..
| // RequeueError custom SyncPeriod in seconds | ||
| RequeueTime *int `json:"requeueTime,omitempty` |
There was a problem hiding this comment.
what happens when someone provides 0?
There was a problem hiding this comment.
Should we panic code-gen?
This changes introduce a new field in generator.yaml SyncedConfig, which lets us define custom reuqueue duration. If it is not defined, the duration will default to the DefaultSyncPeriod
michaelhtm
force-pushed
the
feat/customsyncedrequeueerror
branch
from
0ecfda5 to
9f2bbca
Compare
|
@michaelhtm: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 180d of inactivity. |
ack-prow
bot
added
the
lifecycle/stale
|
Stale issues rot after 60d of inactivity. |
ack-prow
bot
added
lifecycle/rotten
3 participants
Description of changes:
This changes introduce a new field in generator.yaml SyncedConfig, which
lets us define custom reuqueue duration. If it is not defined, the
duration will default to the DefaultSyncPeriod
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.