Skip to content

DeepCopy resource before passing to sdk operations#655

Draft
knottnt wants to merge 1 commit intoaws-controllers-k8s:mainfrom
knottnt:deep-copy-before-sdk-operations
Draft

DeepCopy resource before passing to sdk operations#655
knottnt wants to merge 1 commit intoaws-controllers-k8s:mainfrom
knottnt:deep-copy-before-sdk-operations

Conversation

@knottnt
Copy link
Contributor

@knottnt knottnt commented Jan 2, 2026

Issue #, if available:

Description of changes:
Pass copy of resource to sdk operations to prevent case where sdk operation returns passed in resource, preventing patch of Status.Conditions due to ensureConditions() mutating both desired and latest.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pass copy of resource to sdk operations to prevent case where sdk operation returns passed in resource, preventing patch of Status.Conditions due to ensureConditions() mutating both desired and latest.
@ack-prow
Copy link

ack-prow bot commented Jan 2, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2026
@ack-prow ack-prow bot requested review from a-hilaly and jlbutler January 2, 2026 21:41
@ack-prow
Copy link

ack-prow bot commented Jan 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knottnt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Jan 2, 2026
@knottnt
Copy link
Contributor Author

knottnt commented Jan 2, 2026

/test all

@knottnt
Copy link
Contributor Author

knottnt commented Jan 2, 2026

/retest

4 similar comments
@knottnt
Copy link
Contributor Author

knottnt commented Jan 5, 2026

/retest

@knottnt
Copy link
Contributor Author

knottnt commented Jan 16, 2026

/retest

@knottnt
Copy link
Contributor Author

knottnt commented Jan 20, 2026

/retest

@knottnt
Copy link
Contributor Author

knottnt commented Jan 23, 2026

/retest

@ack-prow
Copy link

ack-prow bot commented Jan 23, 2026

@knottnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 46f36b8 link false /test verify-attribution
s3-olm-test 46f36b8 link false /test s3-olm-test
s3-controller-test 46f36b8 link true /test s3-controller-test
ec2-controller-test 46f36b8 link true /test ec2-controller-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant