DeepCopy resource before passing to sdk operations#655
DeepCopy resource before passing to sdk operations#655knottnt wants to merge 1 commit intoaws-controllers-k8s:mainfrom
Conversation
Pass copy of resource to sdk operations to prevent case where sdk operation returns passed in resource, preventing patch of Status.Conditions due to ensureConditions() mutating both desired and latest.
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knottnt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
@knottnt: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issue #, if available:
Description of changes:
Pass copy of resource to sdk operations to prevent case where sdk operation returns passed in resource, preventing patch of Status.Conditions due to ensureConditions() mutating both desired and latest.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.