Fix map mutation during iteration in renameExportable#668
Fix map mutation during iteration in renameExportable#668a-hilaly wants to merge 1 commit intoaws-controllers-k8s:mainfrom
Conversation
|
/retest |
renameExportable() deletes and inserts map keys while iterating MemberRefs. Go may revisit newly-inserted keys, overwriting OriginalMemberName with the exported name instead of the original. Snapshot keys before iterating to prevent this.
a-hilaly
force-pushed
the
fix-nondeterministic-renames
branch
from
15df356 to
b010374
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@a-hilaly: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
2 participants
renameExportable() deletes and inserts map keys while iterating
MemberRefs. Go may revisit newly-inserted keys, overwriting
OriginalMemberName with the exported name instead of the original.
Snapshot keys before iterating to prevent this.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.