Skip to content

feat: add cel support to specs and fields#677

Open
ecordell wants to merge 1 commit intoaws-controllers-k8s:mainfrom
ecordell:cel-support
Open

feat: add cel support to specs and fields#677
ecordell wants to merge 1 commit intoaws-controllers-k8s:mainfrom
ecordell:cel-support

Conversation

@ecordell
Copy link

Description of changes:

This adds support for custom cel validation rules to both resources and fields:

resources:
  MyResource:
    custom_cel_rules:
      - rule: "has(self.foo)"
        message: "foo is required"
      - rule: "self.bar > 0"
    fields:
      MyField:
        custom_cel_rules:
          - rule: "self.matches('^[a-z]+')"
            message: "must be lowercase"

which translate into // +kubebuilder:validation:XValidation annotations on the generated CRDs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 13, 2026
@ack-prow
Copy link

ack-prow bot commented Mar 13, 2026

Hi @ecordell. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-prow ack-prow bot requested review from knottnt and michaelhtm March 13, 2026 15:19
@ack-prow
Copy link

ack-prow bot commented Mar 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ecordell
Once this PR has been reviewed and has the lgtm label, please assign michaelhtm for approval by writing /assign @michaelhtm in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant