Skip to content

Add support for the EnableNetworkAddressUsageMetrics VPC attribute.#315

Open
knottnt wants to merge 3 commits intoaws-controllers-k8s:mainfrom
knottnt:enable-network-usage-metrics
Open

Add support for the EnableNetworkAddressUsageMetrics VPC attribute.#315
knottnt wants to merge 3 commits intoaws-controllers-k8s:mainfrom
knottnt:enable-network-usage-metrics

Conversation

@knottnt
Copy link
Contributor

@knottnt knottnt commented Mar 4, 2026

Issue #, if available: 1894

Description of changes:
This change adds the ability to get and set the EnableNetworkAddressUsageMetrics attribute on VPCs, following the same pattern used for EnableDNSSupport and EnableDNSHostnames. The attribute is read via DescribeVpcAttribute, set via ModifyVpcAttribute, and is supported during create and update. E2E tests are updated to cover enabling and disabling the attribute.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
Copy link

ack-prow bot commented Mar 4, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2026
@knottnt
Copy link
Contributor Author

knottnt commented Mar 4, 2026

/test all

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler March 4, 2026 20:30
@ack-prow
Copy link

ack-prow bot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knottnt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Mar 4, 2026
@knottnt knottnt force-pushed the enable-network-usage-metrics branch from c9cb7e3 to 9bddf9b Compare March 4, 2026 21:22
@knottnt
Copy link
Contributor Author

knottnt commented Mar 4, 2026

/retest

@knottnt knottnt force-pushed the enable-network-usage-metrics branch from 9bddf9b to 07b9e89 Compare March 4, 2026 21:53
@knottnt
Copy link
Contributor Author

knottnt commented Mar 4, 2026

/test all

@knottnt knottnt changed the title Enable network usage metrics Add support for the EnableNetworkAddressUsageMetrics VPC attribute. Mar 4, 2026
@knottnt knottnt marked this pull request as ready for review March 4, 2026 22:35
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2026
@ack-prow ack-prow bot requested a review from michaelhtm March 4, 2026 22:35
@ack-prow
Copy link

ack-prow bot commented Mar 4, 2026

@knottnt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-verify-attribution 07b9e89 link false /test ec2-verify-attribution

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant