fix: case-insensitive Engine comparison to prevent drift#215
Open
michaelhtm wants to merge 1 commit into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
michaelhtm
force-pushed
the
fix/late-init-engine-field
branch
from
f03524e to
7830a5e
Compare
Contributor
|
/retest |
Contributor
|
@michaelhtm is the PR description correct? The link issue is for the RDS controller and I don't see any changes related to a PreferredAvailabilityZone field. |
Member
Author
|
/retest |
Member
Author
|
@knottnt There are comments in the issue that mention delta issues in ACK in general |
AWS normalizes Engine to lowercase ("redis") but users may specify
"Redis". Add case-insensitive comparison in modifyDelta to suppress
the false delta. Also add skip_incomplete_check to PreferredAvailabilityZone.
Resolves aws-controllers-k8s/community#2695
michaelhtm
force-pushed
the
fix/late-init-engine-field
branch
from
7830a5e to
9a5edf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
AWS normalizes Engine to lowercase ("redis") but users may specify
"Redis". Add case-insensitive comparison in modifyDelta to suppress
the false delta. Also add skip_incomplete_check to PreferredAvailabilityZone.
Resolves aws-controllers-k8s/community#2695
aws-controllers-k8s/community#2695 (comment)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.