feat: add ResolverQueryLogConfig#67
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
michaelhtm
force-pushed
the
feat/add-resolver-query-log-config
branch
from
a6cf8a2 to
924fb59
Compare
|
/test all |
|
/label release/minor |
ack-prow
Bot
added
the
release/minor
knottnt
left a comment
knottnt
left a comment
There was a problem hiding this comment.
Thanks @michaelhtm implementation looks good. Just had a few comments on the e2e tests.
| return session.region_name | ||
|
|
||
|
|
||
| def create_log_destination_bucket(s3_client, bucket_name: str, region: str): |
There was a problem hiding this comment.
Would it be worth it to update our acktest Bucket class to support LocationConstraints?
| bucket_name = f"ack-qlc-test-{account_id}-{config_name[-8:]}" | ||
| destination_arn = f"arn:aws:s3:::{bucket_name}" | ||
|
|
||
| create_log_destination_bucket(s3_client, bucket_name, region) |
There was a problem hiding this comment.
nit: a failure between this and yielding to the test function will result in this bucket being leaked.
michaelhtm
force-pushed
the
feat/add-resolver-query-log-config
branch
from
924fb59 to
4192d91
Compare
Adds support for managing Route 53 Resolver Query Log Configs. Includes tag support via ListTagsForResource/TagResource/UntagResource hooks and custom update method (only tags are mutable). Resolves aws-controllers-k8s/community#2908
michaelhtm
force-pushed
the
feat/add-resolver-query-log-config
branch
from
4192d91 to
bca75f2
Compare
2 participants
Description of changes:
Adds support for managing Route 53 Resolver Query Log Configs. Includes
tag support via ListTagsForResource/TagResource/UntagResource hooks and
custom update method (only tags are mutable).
Resolves aws-controllers-k8s/community#2908
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.