Skip to content

feat: detect secret data changes via resourceVersion tracking#253

Open
michaelhtm wants to merge 1 commit into
aws-controllers-k8s:mainfrom
michaelhtm:feat/secret-delta-detection
Open

feat: detect secret data changes via resourceVersion tracking#253
michaelhtm wants to merge 1 commit into
aws-controllers-k8s:mainfrom
michaelhtm:feat/secret-delta-detection

Conversation

@michaelhtm
Copy link
Copy Markdown
Member

Description of changes:
Track referenced Secret resourceVersions in an annotation on the ACK
resource. On each sdkFind, populate the annotation with current
resourceVersions. Delta compares stored vs fresh values to detect
when secret data changed without a reference struct change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented Jun 2, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-prow ack-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2026
@ack-prow ack-prow Bot requested review from a-hilaly and jlbutler June 2, 2026 21:16
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented Jun 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Track referenced Secret resourceVersions in an annotation on the ACK
resource. On each sdkFind, populate the annotation with current
resourceVersions. Delta compares stored vs fresh values to detect
when secret data changed without a reference struct change.
@michaelhtm michaelhtm force-pushed the feat/secret-delta-detection branch from 62de298 to 08de893 Compare June 3, 2026 22:35
@michaelhtm michaelhtm marked this pull request as ready for review June 4, 2026 20:59
@ack-prow ack-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2026
@ack-prow ack-prow Bot requested a review from knottnt June 4, 2026 20:59
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented Jun 4, 2026

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-controller-test 08de893 link true /test ec2-controller-test
sagemaker-controller-test 08de893 link true /test sagemaker-controller-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant