Fix rendering of zero-length paths and empty polygons - #270
Merged
Conversation
A zero-length turn has coincident endpoints, which tripped the closed-segment check meant for full turns when the node was rendered individually (GDS node rendering, compound subsegment expansion) rather than through the path-level filter. Zero-length continuous-style nodes carry no geometry: expand them to nothing at the pathtopolys node entry point and skip zero-length subsegments in the compound style-pinning loop. As a side effect, zero-length pieces left around overlay terminations no longer emit degenerate zero-area polygons. Fixes #269
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
laylagi
approved these changes
Jul 27, 2026
laylagi
left a comment
laylagi
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero-length path nodes and compound subsegments are now ignored during rendering instead of triggering the coincident-endpoint check meant to detect closed segments. Loops removed by
NoRenderstyling expand toPolgyon{T}[]rather than an empty polygon, which can't be written to GDS and breaks some operations. Closes #269.