Open
Conversation
aws-yishanm
reviewed
Feb 17, 2026
|
|
||
| config = AFM45BBaseInferenceConfig( | ||
| neuron_config, | ||
| config = AFMInferenceConfig( |
There was a problem hiding this comment.
Could you move the test to a different file to follow the structure in the PR Conversation?
Contributor
Author
There was a problem hiding this comment.
I'm not sure I follow - the file is under test/integration/test_model.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated AFM-4.5B-Base contrib model README with correct architecture details, validated accuracy results, and working usage examples. The model uses the Arcee architecture (
arcee-ai/AFM-4.5B-Base) with YaRN RoPE scaling and ReLU² activation. Validation achieved 100% token match accuracy with a deterministic prompt.Model Information
Model Name: AFM-4.5B-Base (Arcee)
Model Architecture: Decoder-only transformer (Arcee — similar to LLaMA with YaRN RoPE and ReLU² activation)
Purpose: Text generation
Checklist
Required Components
test/integration/test_model.py)src/)Optional Components
Folder Structure
Confirm your contribution follows this structure:
Testing
README updated to reflect validated results. Model was compiled and tested with TP=1, batch_size=1, seq_len=128, bfloat16. Token matching achieved 100% on deterministic prompt ("1+1="). Key implementation notes documented: YaRN RoPE scaling, ReLU² activation (no gate_proj), and QKV projection combining for Neuron.
Test Results:
Compatibility
Tested with:
Additional Information
relu(x).pow(2)) replaces SwiGLU — onlyup_projanddown_proj, nogate_projqkv_projfor NeuronRelated Issues
N/A
vLLM Integration
By submitting this PR, I confirm that: