feat: Allow disabling of default anomaly condition#1329
Merged
majanjua-amzn merged 3 commits intomainfrom Mar 9, 2026
Merged
Conversation
97ec509 to
da15cef
Compare
da15cef to
7f51695
Compare
wangzlei
previously approved these changes
Feb 27, 2026
wangzlei
approved these changes
Mar 9, 2026
wangzlei
pushed a commit
that referenced
this pull request
Mar 11, 2026
wangzlei
pushed a commit
that referenced
this pull request
Mar 11, 2026
wangzlei
pushed a commit
that referenced
this pull request
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Currently, when enabling adaptive sampling through the SamplingRateBoost field in a sampling rule the ADOT Java SDK immediately starts capturing 5XX errors as anomalies and this triggers boost behaviour in all services that have spans that match the rule. This is not always desired, so we are providing an option to turn this off per sampling rule.
The new API will have
DisableDefaultAnomalyDetectionset to true in this case.Changes
Testing
./gradlew clean && ./scripts/local_patch.sh && ./gradlew buildBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.