fix(logging): POWERTOOLS_LOG_LEVEL=Trace/Debug no longer ignored#1213
Open
hjgraca wants to merge 1 commit into
Open
fix(logging): POWERTOOLS_LOG_LEVEL=Trace/Debug no longer ignored#1213hjgraca wants to merge 1 commit into
hjgraca wants to merge 1 commit into
Conversation
When no explicit MinimumLogLevel was configured, the Microsoft.Extensions.Logging factory defaulted to Information, silently filtering Trace/Debug before they reached the PowertoolsLoggerProvider. Set the factory minimum to Trace so the provider's env-var-derived filtering is the single source of truth.
powertools-for-aws-oss-automation
Bot
added
the
size/L
github-actions
Bot
added
the
bug
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1213 +/- ##
===========================================
+ Coverage 79.42% 79.46% +0.03%
===========================================
Files 302 302
Lines 12654 12662 +8
Branches 1507 1507
===========================================
+ Hits 10051 10062 +11
+ Misses 2145 2142 -3
Partials 458 458 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #1205
fixes: #1205
Summary
Changes
When no explicit
MinimumLogLevelwas configured (the defaultLogLevel.None), theMicrosoft.Extensions.Loggingfactory kept its default minimum ofInformation, silently filtering Trace/Debug messages before they reachedPowertoolsLoggerProvider. The provider correctly readPOWERTOOLS_LOG_LEVELfrom the environment and set its own minimum, but the factory-level filter had already short-circuitedILogger.IsEnabled()for Trace/Debug.Fix: Set the factory minimum to
LogLevel.Tracewhen no explicit level is configured, so all messages pass through to the provider which handles env-var-derived filtering.Files changed:
LoggerFactoryHelper.CreateAndConfigureFactory— addedelseclause forMinimumLogLevel == NonePowertoolsLoggingBuilderExtensions.AddPowertoolsLogger— setTraceas default factory minimumUser experience
Before: Setting
POWERTOOLS_LOG_LEVEL=TraceorPOWERTOOLS_LOG_LEVEL=Debughad no effect — Trace and Debug calls were silently dropped. OnlyInformationand above would emit.After: Setting
POWERTOOLS_LOG_LEVEL=Traceemits all levels (Trace, Debug, Information, Warning, Error, Critical). SettingPOWERTOOLS_LOG_LEVEL=Debugemits Debug and above. All levels now work as documented.Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.