fix: Return 415 status_code for unsupported content-type headers#7980
Open
chriselion wants to merge 1 commit intoaws-powertools:developfrom
Open
fix: Return 415 status_code for unsupported content-type headers#7980chriselion wants to merge 1 commit intoaws-powertools:developfrom
chriselion wants to merge 1 commit intoaws-powertools:developfrom
Conversation
…return a 415 response
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7980 +/- ##
========================================
Coverage 96.72% 96.73%
========================================
Files 278 278
Lines 13630 13640 +10
Branches 1084 1086 +2
========================================
+ Hits 13184 13194 +10
Misses 327 327
Partials 119 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: closes #7978
Summary
For handlers with a body parameter, previously we would raise an uncaught NotImplementedError, which results in a 500 response.
Now, raise a new subclass of
NotImplementedError(to maintain existing behavior), and handle the new exception and return a 415 (Unsupported Media Type) response.Changes
RequestUnsupportedContentTypeRequestUnsupportedContentTypewhen trying to parse the request body but the content-type header isn't one of the known ones.User experience
Previously, requests for some endpoints would receive a 500 response if they passed unexpected headers.
Now, they will receive a 415 response, which is more indicative of a client error.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.