Update npm.sdk.ts - updated setupForm() call#37
Open
mih-ana wants to merge 1 commit intoaws-samples:masterfrom
Open
Update npm.sdk.ts - updated setupForm() call#37mih-ana wants to merge 1 commit intoaws-samples:masterfrom
mih-ana wants to merge 1 commit intoaws-samples:masterfrom
Conversation
Entering a playback URL inside the url field and clicking the 'Load' button was throwing an error in console and was not loading the newly entered playback url. By updating the setupForm() call inside the npm.sdk.ts file to accept an arrow function instead of a pointer to the method in the demo instance, this error is not thrown anymore and the newly entered playback url is loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Issue #, if available:
Entering a playback URL inside the url field and clicking the 'Load' button was throwing an error in console and was not loading the newly entered playback url.
*Description of changes:
By updating the setupForm() call inside the npm.sdk.ts file to accept an arrow function instead of a pointer to the method in the demo instance, this error is not thrown anymore and the newly entered playback url is loaded.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.