This repository was archived by the owner on May 22, 2025. It is now read-only.
Bug fixed when adding multiple custom conda envs in Jupyter#69
Open
imohammad12 wants to merge 1 commit intoaws-samples:masterfrom
Open
Bug fixed when adding multiple custom conda envs in Jupyter#69imohammad12 wants to merge 1 commit intoaws-samples:masterfrom
imohammad12 wants to merge 1 commit intoaws-samples:masterfrom
Conversation
I think each env should be deactivated after being added as a kernel in Jupyter. The previous version causes the following error for me when I have multiple custom Conda environments. Just the first custom Conda environment in the loop is added correctly. Note that all custom Conda environments will appear on Jupyter, but not all of them work correctly. The error in terminal: Could not find Conda environment: "name_of_the_custom_conda_env"
dmlause
reviewed
Jan 22, 2024
| BASENAME=$(basename "$env") | ||
| source activate "$BASENAME" | ||
| python -m ipykernel install --user --name "$BASENAME" --display-name "Custom ($BASENAME)" | ||
| conda deactivate |
Contributor
There was a problem hiding this comment.
To be consistent, update this to be source deactivate - @imohammad12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Deactivating custom Conda env added in the loop when adding each custom env as a kernel in Jupyter.
More details:
I think each env should be deactivated after being added as a kernel in Jupyter.
The previous version causes the following error for me when I have multiple custom Conda environments. Just the first custom Conda environment in the loop is added correctly. Note that all custom Conda environments will appear on Jupyter, but not all of them work correctly.
The error in terminal:
Could not find Conda environment: "name_of_the_custom_conda_env"
Testing Done
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.