Skip to content

Fix crash when requesting non-existent profile #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rhyru9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix crash when requesting non-existent profile #363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions application/api/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import json
import traceback
from fastapi import APIRouter, WebSocket, WebSocketDisconnect, status
from fastapi import APIRouter, WebSocket, WebSocketDisconnect, status, HTTPException

from nlq.business.log_store import LogManagement
from nlq.business.profile import ProfileManagement
Expand Down Expand Up @@ -33,7 +33,15 @@ def option(id: str=None):
@router.get("/get_custom_question", response_model=CustomQuestion)
def get_custom_question(data_profile: str):
all_profiles = ProfileManagement.get_all_profiles_with_info()
comments = all_profiles[data_profile]['comments']

# FIX: Check if profile exists before accessing
if data_profile not in all_profiles:
raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND,
detail=f"Profile '{data_profile}' not found."
)

comments = all_profiles[data_profile].get('comments', '')
comments_questions = []
if len(comments.split("Examples:")) > 1:
comments_questions_txt = comments.split("Examples:")[1]
Expand Down Expand Up @@ -233,4 +241,4 @@ async def response_websocket(websocket: WebSocket, session_id: str, content,
}
logger.info(content_obj)
final_content = json.dumps(content_obj, default=serialize_timestamp)
await websocket.send_text(final_content)
await websocket.send_text(final_content)