fix(templates): pin google-adk < 2.0.0 to prevent runtime init timeout#1309
Merged
Conversation
github-actions
Bot
added
the
agentcore-harness-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-1309-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.14.0.tgz |
google-adk 2.0.0 was released on 2026-05-19 and significantly increases cold-start import time, pushing GoogleADK agents past the 30s runtime initialization limit. Pin to < 2.0.0 until we validate 2.x compatibility.
notgitika
force-pushed
the
fix/pin-google-adk-below-2
branch
from
3118f6a to
b568126
Compare
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
tejaskash
approved these changes
May 19, 2026
agentcore-cli-automation
approved these changes
May 19, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
LGTM. Minimal, well-targeted fix:
- Adds
< 2.0.0upper bound togoogle-adkin all three GoogleADK templatepyproject.tomlfiles (a2a, agui, http). - Snapshot is updated consistently — verified the three
google-adklines inassets.snapshot.test.ts.snapmatch the three template files. - I grepped the rest of
src/forgoogle-adk/googleadkreferences — no other pyproject templates, docs, or tests need updating. - No test code changes (no mocking concerns) and no new feature surface (no telemetry to add), so the patterns from the review guidelines don't apply here.
Rationale in the PR description (avoid the cold-start regression in google-adk 2.0.0 that pushes runtime init past 30s) is clear and matches the linked failing E2E run.
github-actions
Bot
removed
the
agentcore-harness-reviewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google-adkto< 2.0.0in all three GoogleADK template pyproject.toml files (http, a2a, agui)google-adk 2.0.0was released 2026-05-19T16:17 UTC and significantly increases cold-start import time (~2.5s locally for justgoogle.adk.agents), pushing GoogleADK agents past the 30s runtime initialization limit in E2E>= 1.17.0to the newly-published 2.0.0Test plan
googleadk-geminiinit timeout