fix(dev): use TUI picker for deploy when launching dev from interactive menu#1409
Closed
jesseturner21 wants to merge 1 commit into
Closed
fix(dev): use TUI picker for deploy when launching dev from interactive menu#1409jesseturner21 wants to merge 1 commit into
jesseturner21 wants to merge 1 commit into
Conversation
…ve menu When selecting "dev" from the interactive `agentcore` menu, harness deploy was rendered inline via runCliDeploy() instead of using the full-screen TUI (DevScreen) that `agentcore dev` uses directly. This made the two paths visually inconsistent. Now launchBrowserDev() uses launchTuiDevScreenWithPicker() — the same alt-screen TUI picker used by the direct `agentcore dev` command — so deploy progress renders identically regardless of entry path. Closes #1376 Constraint: Must match the existing agentcore dev direct-invocation UX Rejected: Adding ENTER_ALT_SCREEN around runCliDeploy | would still show spinner-based output instead of the structured DevScreen TUI Confidence: high Scope-risk: narrow
github-actions
Bot
added
the
agentcore-harness-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
github-actions
Bot
removed
the
agentcore-harness-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Contributor
Coverage Report
|
Contributor
Author
|
Closing — fix should target main with isPreviewEnabled gate, not preview branch directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentcore→ select "dev" rendered harness deploy inline (text spinners), whileagentcore devused the full-screen TUI (DevScreen) with structured deploy progresslaunchBrowserDev()now useslaunchTuiDevScreenWithPicker()— the same alt-screen TUI picker used by the directagentcore devcommandCloses #1376
Test plan
launchBrowserDevverifying it uses the TUI picker pathagentcore create→cdinto project →agentcore→ select "dev" → verify deploy uses full-screen TUIagentcore dev→ verify same full-screen TUI deploy experience