Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
permissions:
contents: read

env:
AGENTCORE_TELEMETRY_DISABLED: '1'

# Cancel in-progress runs for PRs; never cancel runs on main (merges should not abort each other)
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/e2e-tests-full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ on:
push:
branches: [main]

env:
AGENTCORE_TELEMETRY_DISABLED: '1'

concurrency:
group: e2e-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: false
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ jobs:
runs-on: ubuntu-latest
environment: e2e-testing
timeout-minutes: 30
env:
AGENTCORE_TELEMETRY_DISABLED: '1'
steps:
- uses: actions/checkout@v6
with:
Expand Down
32 changes: 0 additions & 32 deletions integ-tests/telemetry.test.ts

This file was deleted.

5 changes: 4 additions & 1 deletion src/cli/commands/telemetry/__tests__/telemetry.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ const tmp = createTempConfig('actions');
describe('telemetry actions', () => {
const originalEnv = process.env;

beforeEach(() => tmp.setup());
beforeEach(async () => {
await tmp.setup();
delete process.env.AGENTCORE_TELEMETRY_DISABLED;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test below is enabling telemetry, then verifying its enabled. Having this env var overrides that, so we delete it for this test scope to keep the original test.

});

afterEach(() => {
process.env = originalEnv;
Expand Down
Loading