Skip to content

fix(e2e): address failing byo e2e tests. #1476

Merged
jariy17 merged 3 commits into
aws:mainfrom
Hweinstock:fix/e2e-tests-1
Jun 8, 2026
Merged

fix(e2e): address failing byo e2e tests. #1476
jariy17 merged 3 commits into
aws:mainfrom
Hweinstock:fix/e2e-tests-1

Conversation

@Hweinstock

@Hweinstock Hweinstock commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Problem

See #1441 for failing test information.

Solution

  • loosen regex and add result assertions.
  • add more detailed logging on failures.
  • avoid always using cdk main for byo tests.

Testing

ran e2e tests via scripts/run-e2e-local.sh.

 ✓  e2e  e2e-tests/strands-bedrock-byo-filesystem.test.ts > e2e: Strands/Bedrock — create → deploy → invoke > deplo
ys to AWS successfully 92511ms
 ✓  e2e  e2e-tests/strands-bedrock-byo-filesystem.test.ts > e2e: Strands/Bedrock — create → deploy → invoke > invok
es the deployed agent 27705ms
 ✓  e2e  e2e-tests/strands-bedrock-byo-filesystem.test.ts > e2e: Strands/Bedrock — create → deploy → invoke > statu
s shows the deployed agent 9672ms
 ✓  e2e  e2e-tests/strands-bedrock-byo-filesystem.test.ts > e2e: Strands/Bedrock — create → deploy → invoke > statu
s looks up agent runtime by ID 8923ms
 ✓  e2e  e2e-tests/strands-bedrock-byo-filesystem.test.ts > e2e: Strands/Bedrock — create → deploy → invoke > logs 
returns entries from the invocation 9960ms
 ✓  e2e  e2e-tests/strands-bedrock-byo-filesystem.test.ts > e2e: Strands/Bedrock — create → deploy → invoke > logs 
supports level filtering 9988ms
 ✓  e2e  e2e-tests/strands-bedrock-byo-filesystem.test.ts > e2e: Strands/Bedrock — create → deploy → invoke > trace
s list succeeds after invocation 2642ms
 ✓  e2e  e2e-tests/byo-custom-jwt.test.ts > e2e: BYO agent with CUSTOM_JWT auth > deploys with CUSTOM_JWT authorize
r configuration 244869ms
 ✓  e2e  e2e-tests/byo-custom-jwt.test.ts > e2e: BYO agent with CUSTOM_JWT auth > rejects SigV4 invocation (auth me
thod mismatch) 6352ms
 ✓  e2e  e2e-tests/byo-custom-jwt.test.ts > e2e: BYO agent with CUSTOM_JWT auth > invokes with bearer token success
fully 6982ms
 ✓  e2e  e2e-tests/byo-custom-jwt.test.ts > e2e: BYO agent with CUSTOM_JWT auth > MCP agent: rejects SigV4 invocati
on (auth method mismatch) 6363ms
 ✓  e2e  e2e-tests/byo-custom-jwt.test.ts > e2e: BYO agent with CUSTOM_JWT auth > MCP agent: lists tools with beare
r token 6535ms
 ✓  e2e  e2e-tests/byo-custom-jwt.test.ts > e2e: BYO agent with CUSTOM_JWT auth > MCP agent: calls tool with bearer
 token 6561ms
 ✓  e2e  e2e-tests/byo-custom-jwt.test.ts > e2e: BYO agent with CUSTOM_JWT auth > status shows the deployed agent 9
435ms

 Test Files  2 passed (2)
      Tests  14 passed (14)
   Start at  17:21:53
   Duration  413.64s (transform 274ms, setup 0ms, import 2.27s, tests 680.94s, environment 0ms)

@github-actions github-actions Bot added the size/s PR size: S label Jun 8, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 8, 2026
@Hweinstock Hweinstock changed the title Fix/e2e tests 1 fix(e2e): address failing byo e2e tests. Jun 8, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jun 8, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jun 8, 2026
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.18.0.tgz

How to install

gh release download pr-1476-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.18.0.tgz

@agentcore-cli-automation agentcore-cli-automation left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Small note inline about the regex narrowing for the SigV4 rejection assertions — non-blocking, since the test setup makes the client-side fast-fail the only realistic path. The detailed-logging additions and the installCdkTarball/writeAwsTargets extraction are nice cleanups.

Comment thread e2e-tests/byo-custom-jwt.test.ts Outdated
@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 8, 2026
@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels Jun 8, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jun 8, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jun 8, 2026
@Hweinstock Hweinstock marked this pull request as ready for review June 8, 2026 18:06
@Hweinstock Hweinstock requested a review from a team June 8, 2026 18:06
@jariy17 jariy17 merged commit 5d10867 into aws:main Jun 8, 2026
26 of 27 checks passed
@Hweinstock Hweinstock deleted the fix/e2e-tests-1 branch June 8, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants