chore: update e2e test script to include new paramters#1477
Merged
Conversation
github-actions
Bot
added
the
agentcore-harness-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-1477-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.18.0.tgz |
agentcore-cli-automation
approved these changes
Jun 8, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
LGTM. The new env var exports match exactly what e2e-tests/strands-bedrock-byo-filesystem.test.ts reads (E2E_EFS_ACCESS_POINT_ARN, E2E_S3_ACCESS_POINT_ARN, E2E_FILESYSTEM_SUBNET_ID, E2E_FILESYSTEM_SECURITY_GROUP_ID) and what .github/workflows/e2e-tests.yml / e2e-tests-full.yml set, so the local script is now back in parity with CI.
github-actions
Bot
removed
the
agentcore-harness-reviewing
Hweinstock
commented
Jun 8, 2026
| echo "=== Configuring git (required for agentcore create) ===" | ||
| git config --global user.email "ci@local" 2>/dev/null || true | ||
| git config --global user.name "Local E2E" 2>/dev/null || true | ||
| git config --global user.name "Local E2E" 2>/dev/null || true |
Contributor
Author
There was a problem hiding this comment.
side effect of npm run format
notgitika
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scripts are missing new BYO required env vars.
Related Issue
N/A
Closes #
Documentation PR
N/A
Type of Change
Testing
Used the script for debugging.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.