docs(permissions): update permissions role to include new permissions BYOF#1483
Merged
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
Package TarballHow to installgh release download pr-1483-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.18.0.tgz |
agentcore-cli-automation
approved these changes
Jun 8, 2026
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Reviewed the diff against the BYOF code paths in src/cli/commands/shared/filesystem-utils.ts, src/cli/primitives/AgentPrimitive.tsx, src/cli/tui/screens/agent/useAddAgent.ts, and src/cli/tui/screens/create/useCreateFlow.ts. Each of the seven permissions added to the FilesystemNetworkValidation Sid maps directly to a real SDK call:
ec2:DescribeSecurityGroups→DescribeSecurityGroupsCommand(filesystem-utils.ts:214, 348)ec2:DescribeSubnets→DescribeSubnetsCommand(filesystem-utils.ts:317, 417; AgentPrimitive.tsx:386; useAddAgent.ts:230)elasticfilesystem:DescribeAccessPoints→DescribeAccessPointsCommand(filesystem-utils.ts:174)elasticfilesystem:DescribeMountTargets→DescribeMountTargetsCommand(filesystem-utils.ts:248)elasticfilesystem:DescribeMountTargetSecurityGroups→DescribeMountTargetSecurityGroupsCommand(filesystem-utils.ts:253)s3files:ListMountTargets→ListMountTargetsCommand(filesystem-utils.ts:193, 274)s3files:GetMountTarget→GetMountTargetCommand(filesystem-utils.ts:279)
JSON is valid, the new Sid is also referenced from the "Scoping down by feature" table, and the e2e run in the PR description confirms the policy works end-to-end. No code changes needed. LGTM.
jariy17
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
e2e test role is missing a ton of permissions for the new BYOF feature.
#1441
Solution
Testing