Skip to content

feat(ci): shard integ tests for faster runs. #1484

Merged
Hweinstock merged 2 commits into
aws:mainfrom
Hweinstock:feat/shard-integ-tests
Jun 10, 2026
Merged

feat(ci): shard integ tests for faster runs. #1484
Hweinstock merged 2 commits into
aws:mainfrom
Hweinstock:feat/shard-integ-tests

Conversation

@Hweinstock

@Hweinstock Hweinstock commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Problem

Integ tests have become the bottleneck on PR CI runs.
#1487

Solution

  • shard them across 4 runners.
  • also centralize on same git email that e2e tests use.

Testing

  • see tests on PR. No sharding took 11 min, sharding took: 4 min 50 sec. over 50% reduction.

@github-actions github-actions Bot added the size/s PR size: S label Jun 8, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 8, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jun 8, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jun 8, 2026
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.18.0.tgz

How to install

gh release download pr-1484-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.18.0.tgz

@agentcore-cli-automation agentcore-cli-automation left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. The sharding approach is correct (vitest --shard=N/M splits at the file level, and 18 integ test files / 4 shards is reasonable), and the new shards are passing on this PR (~2m50s each, vs the previous serial integ run). Email change to ci@amazon.com aligns with e2e-tests.yml and e2e-tests-full.yml as described.

Couple of minor non-blocking observations (no changes needed):

  • .github/workflows/pr-tarball.yml:42 still uses the old bedrock-agentcore-npm+ci@amazon.com — outside the stated scope of this PR, but worth a follow-up if the goal is to fully centralize.
  • unit-test is sharded 3-ways while integ-test is sharded 4-ways; assuming this reflects relative durations, that's fine.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 8, 2026
@Hweinstock Hweinstock marked this pull request as ready for review June 8, 2026 21:11
@Hweinstock Hweinstock requested a review from a team June 8, 2026 21:11
@Hweinstock Hweinstock merged commit 9f755cb into aws:main Jun 10, 2026
34 checks passed
@Hweinstock Hweinstock deleted the feat/shard-integ-tests branch June 10, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants