feat(ci): shard integ tests for faster runs. #1484
Merged
Merged
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
Package TarballHow to installgh release download pr-1484-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.18.0.tgz |
agentcore-cli-automation
approved these changes
Jun 8, 2026
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Looks good to merge. The sharding approach is correct (vitest --shard=N/M splits at the file level, and 18 integ test files / 4 shards is reasonable), and the new shards are passing on this PR (~2m50s each, vs the previous serial integ run). Email change to ci@amazon.com aligns with e2e-tests.yml and e2e-tests-full.yml as described.
Couple of minor non-blocking observations (no changes needed):
.github/workflows/pr-tarball.yml:42still uses the oldbedrock-agentcore-npm+ci@amazon.com— outside the stated scope of this PR, but worth a follow-up if the goal is to fully centralize.unit-testis sharded 3-ways whileinteg-testis sharded 4-ways; assuming this reflects relative durations, that's fine.
avi-alpert
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Integ tests have become the bottleneck on PR CI runs.
#1487
Solution
Testing