Skip to content

fix(ci): avoid formatting lock file#1489

Merged
Hweinstock merged 1 commit into
aws:mainfrom
Hweinstock:fix/dont-format-lock-file
Jun 9, 2026
Merged

fix(ci): avoid formatting lock file#1489
Hweinstock merged 1 commit into
aws:mainfrom
Hweinstock:fix/dont-format-lock-file

Conversation

@Hweinstock

@Hweinstock Hweinstock commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Problem

See #1488, formatter is running on generated file causing dependabot PRs to fail CI. Since the file is generated, this check will always fail on updating, causing noise in CI and pre-commit.

Solution

  • add shrinkwrap to prettier ignore file.

Testing

# regenerated the file
npm shrinkwrap
npm run format:check 
# I see the failure here. 
# update the .prettierignore
npm run format:check
# now it passes

@github-actions github-actions Bot added the size/xs PR size: XS label Jun 9, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 9, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jun 9, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.18.0.tgz

How to install

gh release download pr-1489-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.18.0.tgz

@agentcore-cli-automation agentcore-cli-automation left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. Single-line fix to .prettierignore correctly addresses #1488npm-shrinkwrap.json is a generated file and shouldn't be subject to formatting. Verified the testing steps in the PR description make sense, and there are no related references to shrinkwrap formatting elsewhere in the repo (CI scripts, bundle script, etc.) that this could affect.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 9, 2026
@Hweinstock Hweinstock marked this pull request as ready for review June 9, 2026 13:48
@Hweinstock Hweinstock requested a review from a team June 9, 2026 13:48
@Hweinstock Hweinstock merged commit d34b823 into aws:main Jun 9, 2026
30 checks passed
@Hweinstock Hweinstock deleted the fix/dont-format-lock-file branch June 9, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants