fix(ci): avoid formatting lock file#1489
Merged
Merged
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
Package TarballHow to installgh release download pr-1489-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.18.0.tgz |
agentcore-cli-automation
approved these changes
Jun 9, 2026
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Looks good to merge. Single-line fix to .prettierignore correctly addresses #1488 — npm-shrinkwrap.json is a generated file and shouldn't be subject to formatting. Verified the testing steps in the PR description make sense, and there are no related references to shrinkwrap formatting elsewhere in the repo (CI scripts, bundle script, etc.) that this could affect.
aidandaly24
approved these changes
Jun 9, 2026
avi-alpert
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
See #1488, formatter is running on generated file causing dependabot PRs to fail CI. Since the file is generated, this check will always fail on updating, causing noise in CI and pre-commit.
Solution
Testing